Hi Bill,
This isn't uncommon at all. Did you get a chance to see a physio while you were an inpatient?
The main advice we give you as an inpatient is 1. ensure you have adequate pain releif 2. Do breathing exercises regularly during the day.
The Ribs aren't the main problem - like the doctor said they should heal - its the risk of pneumonia that comes with hypoventilation as a responce to pain.
You should be moving around as much as pain tolerates, don't be alarmed by the clicking of the ribs (yes it is the bones moving), it's normal/common. Moving helps to move sputum from inside the lungs (phlegm is sheer dependant - if it's vibrated it becomes thinner and easier to move).
Sleeping upright will help you to breath easier in the night, but you don't specifically have to do this unless you are having trouble breathing in the night.
If you get pain with coughing you can get a pillow and place it under your shoulder and splint the ribs during the action.
The shoulder will loose some Range of motion without use. So try to move it through it's range at least once a day - but if it causes you pain dont' worry too much you can dig into shoulder movement when the ribs are healed (though it's easier to just not loose the movement in the first place)
If start to feel unwell, get a fever or you start to cough a lot more and produce green aromatic (not in a good way) sputum then you should be revisiting your GP as you likely have a pneumonia and the antibiotics you should be on aren't cutting it.
Best thing you can do is get on with your life while maintaining a level of analgesia adequate to let you breath normally.
Have a great one,
Puddin'