Any history of previous shoulder trauma? if he has had previous dislocation he could have a Hill-Sachs lesion or a Bankart lesion. is the clunking painful anyway? is it only pull ups that cause the clunking?